Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19186 )
Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables ...................................................................... Patch Set 2: Code-Review+1 nit: Didn't go through the usages, but is there any reason we can't use expectedWarning == null as the condition for zero warning? Do we actually use it loosely, when we don't provide the expected warnings? -- To view, visit http://gerrit.cloudera.org:8080/19186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0871b94dcd2290723699c21227a576e8a6a09b5a Gerrit-Change-Number: 19186 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 01 Dec 2022 11:11:29 +0000 Gerrit-HasComments: No
