Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19186 )
Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables ...................................................................... Patch Set 2: Code-Review+1 (1 comment) This looks good. Just saw one change that doesn't seem necessary, I'd like a response on that before I +2. http://gerrit.cloudera.org:8080/#/c/19186/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/19186/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java@57 PS2, Line 57: return AnalyzesOk(stmt, createAnalysisCtx(Catalog.DEFAULT_DB), null, false); Doesn't seem like this needed to be updated because there's a version that takes 3 arguments. -- To view, visit http://gerrit.cloudera.org:8080/19186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0871b94dcd2290723699c21227a576e8a6a09b5a Gerrit-Change-Number: 19186 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 01 Dec 2022 17:16:02 +0000 Gerrit-HasComments: Yes
