Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19084 )
Change subject: IMPALA-11158: Add support for Iceberg tables with AVRO data files ...................................................................... Patch Set 4: (10 comments) The change looks great, Noemi. Added some comments, I will do another round a bit later. http://gerrit.cloudera.org:8080/#/c/19084/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19084/4//COMMIT_MSG@13 PS4, Line 13: I think we should add that Impala will use its avro scanner to read AVRO files, therefore the avro related limitation will apply here as well: writes/metadata changes are not supported. http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@32 PS4, Line 32: import java.util.HashSet; nit: unused import http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@68 PS4, Line 68: import org.apache.impala.common.ImpalaRuntimeException; nit: unused import http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@706 PS4, Line 706: nit: empty line http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1754 PS4, Line 1754: boolean isIcebergAvro = false; Unused variable. http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@3116 PS4, Line 3116: public boolean hasAvroData() { : if (getFileFormats().contains(HdfsFileFormat.AVRO)) { : hasAvroData_ = true; : } : return hasAvroData_; : } This method looks unused. http://gerrit.cloudera.org:8080/#/c/19084/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/19084/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@5050 PS3, Line 5050: AnalysisError("CREATE TABLE tbl1 (i int, p1 int, p2 timestamp) " + nit: empty line http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@5056 PS4, Line 5056: nit: empty line http://gerrit.cloudera.org:8080/#/c/19084/3/testdata/datasets/functional/schema_constraints.csv File testdata/datasets/functional/schema_constraints.csv: http://gerrit.cloudera.org:8080/#/c/19084/3/testdata/datasets/functional/schema_constraints.csv@95 PS3, Line 95: parquet Shouldn't we use "avro" here? http://gerrit.cloudera.org:8080/#/c/19084/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test: http://gerrit.cloudera.org:8080/#/c/19084/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test@669 PS4, Line 669: ==== Could we have a negative test for table alteration as well? -- To view, visit http://gerrit.cloudera.org:8080/19084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I827e5707e54bebabc614e127daa48255f86f4c4f Gerrit-Change-Number: 19084 Gerrit-PatchSet: 4 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Mon, 07 Nov 2022 13:49:04 +0000 Gerrit-HasComments: Yes
