Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19084 )
Change subject: IMPALA-11158: Add support for Iceberg tables with AVRO data files ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19084/5/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/19084/5/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@62 PS5, Line 62: boolean hasParquet = false; : boolean hasOrc = false; : boolean hasAvro = false; : for (FileDescriptor fileDesc : fileDescs_) { : byte fileFormat = fileDesc.getFbFileMetadata().icebergMetadata().fileFormat(); : if (fileFormat == FbIcebergDataFileFormat.PARQUET) { : hasParquet = true; : } else if (fileFormat == FbIcebergDataFileFormat.ORC) { : hasOrc = true; : } else if (fileFormat == FbIcebergDataFileFormat.AVRO) { : hasAvro = true; : } else { : throw new ImpalaRuntimeException(String.format( : "Invalid Iceberg file format of file: %s", fileDesc.getAbsolutePath())); : } : } : if (hasParquet) fileFormats_.add(HdfsFileFormat.PARQUET); : if (hasOrc) fileFormats_.add(HdfsFileFormat.ORC); : if (hasAvro) fileFormats_.add(HdfsFileFormat.AVRO); As I understand, now IcebergContentFileStore does this right? We could get a ref with (FeIcebergTable)tblRef.getTable(); and use its flags instead of doing it here again manually (we will need to add hasOrc() and hasParquet() methods too to the store). -- To view, visit http://gerrit.cloudera.org:8080/19084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I827e5707e54bebabc614e127daa48255f86f4c4f Gerrit-Change-Number: 19084 Gerrit-PatchSet: 5 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 28 Nov 2022 09:53:48 +0000 Gerrit-HasComments: Yes
