Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19084 )
Change subject: IMPALA-11158: Add support for Iceberg tables with AVRO data files ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@32 PS4, Line 32: import java.util.LinkedHa > nit: unused import Done http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@68 PS4, Line 68: import org.apache.impala.common.PrintUtils; > nit: unused import Done http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@706 PS4, Line 706: } > nit: empty line Since IcebergContentFileStore will contain the file formats, this function is uneccesary. http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1754 PS4, Line 1754: if (HdfsFileFormat.fromJavaCla > Unused variable. Done http://gerrit.cloudera.org:8080/#/c/19084/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@3116 PS4, Line 3116: : : : : : > This method looks unused. Done http://gerrit.cloudera.org:8080/#/c/19084/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/19084/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@5050 PS3, Line 5050: AnalysisError("CREATE TABLE tbl1 (i int, p1 int, p2 timestamp) " + > nit: empty line Done http://gerrit.cloudera.org:8080/#/c/19084/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test: http://gerrit.cloudera.org:8080/#/c/19084/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test@669 PS4, Line 669: ==== > Could we have a negative test for table alteration as well? TODO -- To view, visit http://gerrit.cloudera.org:8080/19084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I827e5707e54bebabc614e127daa48255f86f4c4f Gerrit-Change-Number: 19084 Gerrit-PatchSet: 5 Gerrit-Owner: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Thu, 24 Nov 2022 10:09:02 +0000 Gerrit-HasComments: Yes
