Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19233 )
Change subject: IMPALA-11720: Deflake FileMetadataLoaderTest due to FileSystem closed ...................................................................... Patch Set 1: Code-Review-1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19233/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19233/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@871 PS1, Line 871: TMP_DIR_PREFIX_LIST.add(".tmp_"); This is wrong, it should be "tmp_.". Strong argument for moving the const strings out of FileSystemUtilTest so we can also use them here. http://gerrit.cloudera.org:8080/#/c/19233/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@873 PS1, Line 873: LOG.warn("BackendConfig uninitialized. Use hard-coded prefix-list. This should " + This seems reasonable. BackendConfig in tests seems kind of fraught. Avoiding initializing it here is a good thing. Although we now have 3 places that reproduce most of this list, it'd be nice to prune that down. -- To view, visit http://gerrit.cloudera.org:8080/19233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6f96950210c9a0124fe03696ef334cb00b057ab Gerrit-Change-Number: 19233 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 11 Nov 2022 18:05:34 +0000 Gerrit-HasComments: Yes
