Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19233 )
Change subject: IMPALA-11720: Deflake FileMetadataLoaderTest due to FileSystem closed ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19233/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19233/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@871 PS1, Line 871: static { > This is wrong, it should be "tmp_.". Strong argument for moving the const s Oops! Nice catch! http://gerrit.cloudera.org:8080/#/c/19233/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@873 PS1, Line 873: // getIgnoredDirPrefixList() could return null if BackendConfig is created with > This seems reasonable. BackendConfig in tests seems kind of fraught. Avoidi I realized that external FE could also run into this (IMPALA-10515). Added null check for getIgnoredDirPrefixList() and removed the sentence about test. I only found 2 places producing this list here. In FileSystemUtilTest we just use the constants. Maybe I miss one? -- To view, visit http://gerrit.cloudera.org:8080/19233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6f96950210c9a0124fe03696ef334cb00b057ab Gerrit-Change-Number: 19233 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 11 Nov 2022 22:14:17 +0000 Gerrit-HasComments: Yes
