Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 )
Change subject: IMPALA-11730: Add support for spilling to Ozone ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/19251/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19251/2//COMMIT_MSG@10 PS2, Line 10: `ofs` > We can require that users provide the port to use this. Done http://gerrit.cloudera.org:8080/#/c/19251/5/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/19251/5/be/src/runtime/tmp-file-mgr.cc@1358 PS5, Line 1358: HDFS, Ozon > nit. may need to add Ozone in the comment. Done http://gerrit.cloudera.org:8080/#/c/19251/2/testdata/cluster/admin File testdata/cluster/admin: http://gerrit.cloudera.org:8080/#/c/19251/2/testdata/cluster/admin@342 PS2, Line 342: > Ok, this seems to be an issue locally because I probably triggered an "upgr Done -- To view, visit http://gerrit.cloudera.org:8080/19251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5837c30357363f727ca832fb94169f2474fb4f6f Gerrit-Change-Number: 19251 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 21 Nov 2022 19:01:42 +0000 Gerrit-HasComments: Yes
