Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 )
Change subject: IMPALA-11730: Add support for spilling to Ozone ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/19251/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19251/7//COMMIT_MSG@17 PS7, Line 17: Refactors TmpDir to remove extraneous variables and functions. Each : implementation is expected to handle its own token parsing. > Turns out they're not exactly unit tests, they require a running HDFS/Ozone Yeah, some tests require a running hdfs server, that should be the reason why they fail. http://gerrit.cloudera.org:8080/#/c/19251/7/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/19251/7/be/src/runtime/tmp-file-mgr.cc@693 PS7, Line 693: The priority > I don't see a typo, that's the correct spelling of priority. I think the first option should be bytes limit. http://gerrit.cloudera.org:8080/#/c/19251/7/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/19251/7/tests/common/skip.py@104 PS7, Line 104: not_scratch_fs = pytest.mark.skipif(not (IS_HDFS or IS_OZONE), > Filed https://issues.apache.org/jira/browse/IMPALA-11765 to follow up on en Ack. -- To view, visit http://gerrit.cloudera.org:8080/19251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5837c30357363f727ca832fb94169f2474fb4f6f Gerrit-Change-Number: 19251 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 02 Dec 2022 22:00:48 +0000 Gerrit-HasComments: Yes
