Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 )
Change subject: IMPALA-11730: Add support for spilling to Ozone ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/19251/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19251/7//COMMIT_MSG@15 PS7, Line 15: . > Would be good to mention the testcases that have been passed. I'll add a note about testing. I haven't made any effort to get backend tests running with Ozone, that's pretty good that only DIskIoMgrTest seems to fail. http://gerrit.cloudera.org:8080/#/c/19251/7//COMMIT_MSG@17 PS7, Line 17: Refactors TmpDir to remove extraneous variables and functions. Each : implementation is expected to handle its own token parsing. > Could you also add ofs to the parsing unit test TestDirectoryLimitParsingRe Looks like 3 unit tests fail with Ozone: 47 - tmp-file-mgr-test (Failed) 54 - buffer-pool-test (Subprocess aborted) 58 - disk-io-mgr-test (Failed) I can look into fixing them up. http://gerrit.cloudera.org:8080/#/c/19251/7/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/19251/7/be/src/runtime/tmp-file-mgr.cc@693 PS7, Line 693: The priority > nit. a typo from the old code, would be good to fix. I don't see a typo, that's the correct spelling of priority. -- To view, visit http://gerrit.cloudera.org:8080/19251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5837c30357363f727ca832fb94169f2474fb4f6f Gerrit-Change-Number: 19251 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 02 Dec 2022 19:12:01 +0000 Gerrit-HasComments: Yes
