Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 )
Change subject: IMPALA-11730: Add support for spilling to Ozone ...................................................................... Patch Set 9: Code-Review+1 (2 comments) It looks good to me. Thanks for the patch. One minor issue is that one change on the testcase may need to review. http://gerrit.cloudera.org:8080/#/c/19251/9/be/src/runtime/tmp-file-mgr-test.cc File be/src/runtime/tmp-file-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/19251/9/be/src/runtime/tmp-file-mgr-test.cc@1163 PS9, Line 1163: Substitute("$0,$1,/tmp/local-buffer-dir", hdfs_path, REMOTE_URL + "/tmp") I think here changes the test logic, the old code uses a different port number to make it a different path, and verify that only the first remote path is accepted. But after the change, two remote paths can be the same, maybe change the later remote path to REMOTE_URL + "/tmp1" would be good to make it different. http://gerrit.cloudera.org:8080/#/c/19251/9/be/src/runtime/tmp-file-mgr-test.cc@1169 PS9, Line 1169: REMOTE_URL Same as above. -- To view, visit http://gerrit.cloudera.org:8080/19251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5837c30357363f727ca832fb94169f2474fb4f6f Gerrit-Change-Number: 19251 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 05 Dec 2022 03:24:24 +0000 Gerrit-HasComments: Yes
