Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 )
Change subject: IMPALA-11717: Use rapidjson for printing collections ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19309/1/be/src/service/hs2-util.cc File be/src/service/hs2-util.cc: http://gerrit.cloudera.org:8080/#/c/19309/1/be/src/service/hs2-util.cc@397 PS1, Line 397: const int item_byte_size = item_tuple_desc->byte_size(); This section (dchecks, starts, stops) could be separated as MapToJSON and ArrayToJson. It would require less conditionals and the key/value conversion would be more visible (L433 is a bit cryptic in this manner) http://gerrit.cloudera.org:8080/#/c/19309/1/be/src/service/hs2-util.cc@528 PS1, Line 528: } else { We could use coll_val as well -- To view, visit http://gerrit.cloudera.org:8080/19309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08a2d596a498fbbaf1419b18284846b992f49165 Gerrit-Change-Number: 19309 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 06 Dec 2022 14:43:54 +0000 Gerrit-HasComments: Yes
