Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 )
Change subject: IMPALA-11717: Use rapidjson for printing collections ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19309/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19309/2//COMMIT_MSG@13 PS2, Line 13: HS2 As we have discussed offline, it would be nicer to have the same logic in HS2 and Beeswax and delete the old json writer code for collections. A new class could be created with responsibility of writing complex types to JSON with rapidjson and this could be called both from HS2 and Beeswax. This would also allow returning structs from beeswax. http://gerrit.cloudera.org:8080/#/c/19309/2/be/src/service/hs2-util.cc File be/src/service/hs2-util.cc: http://gerrit.cloudera.org:8080/#/c/19309/2/be/src/service/hs2-util.cc@535 PS2, Line 535: : rapidjson::StringBuffer buffer; optimization idea: reusing the buffer in the FOREACH_ROW_LIMIT loop could reduce the number of allocations rapidjson::StringBuffer has a Clear() function that resets the buffer without actually deleting the allocated memory, so it could be called after buffer.GetString() -- To view, visit http://gerrit.cloudera.org:8080/19309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08a2d596a498fbbaf1419b18284846b992f49165 Gerrit-Change-Number: 19309 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 06 Dec 2022 15:55:11 +0000 Gerrit-HasComments: Yes
