Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 )
Change subject: IMPALA-11717: Use rapidjson for printing collections ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19309/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19309/2//COMMIT_MSG@13 PS2, Line 13: HS2 > Created a new class with the json writing logic. I'm not sure if I'll add B I think that this should depend on the complexity of the change. - it would be much better to avoid having a different logic for collections in HS2 and Beeswax - if already doing it for collections in Beeswax, then adding struct support also shouldn't be too hard, but I have no problem with moving this to another patch -- To view, visit http://gerrit.cloudera.org:8080/19309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08a2d596a498fbbaf1419b18284846b992f49165 Gerrit-Change-Number: 19309 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 08 Dec 2022 16:34:48 +0000 Gerrit-HasComments: Yes
