Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 )
Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/19429/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19429/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking Do I understand it correctly that the error occurs if we try to query a star on a table/view, not when we try to query a star on a struct? Such as the example in the Jira: select v.* from masked_view v; ERROR: IllegalStateException: null If so, could you make this clear in the commit message, and include the example here? http://gerrit.cloudera.org:8080/#/c/19429/1//COMMIT_MSG@10 PS1, Line 10: While Nit: When http://gerrit.cloudera.org:8080/#/c/19429/1//COMMIT_MSG@11 PS1, Line 11: haven Nit: hadn't http://gerrit.cloudera.org:8080/#/c/19429/1//COMMIT_MSG@12 PS1, Line 12: the table masking view can't expose complex type columns directly Is it still true? If so, can't we / should we change table masking views so that they can expose complex types too? http://gerrit.cloudera.org:8080/#/c/19429/1//COMMIT_MSG@32 PS1, Line 32: - The type is STRUCT Could you make it clearer that these are the conditions for returning the paths directly? It wasn't obvious for me. http://gerrit.cloudera.org:8080/#/c/19429/1//COMMIT_MSG@33 PS1, Line 33: root Nit: rooted? http://gerrit.cloudera.org:8080/#/c/19429/1/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test File testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test: http://gerrit.cloudera.org:8080/#/c/19429/1/testdata/workloads/functional-query/queries/QueryTest/ranger_column_masking_complex_types.test@63 PS1, Line 63: e Nit: expanding. -- To view, visit http://gerrit.cloudera.org:8080/19429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f1e78e325baafbe23101909d47e82bf140a2d77 Gerrit-Change-Number: 19429 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 18 Jan 2023 11:07:06 +0000 Gerrit-HasComments: Yes
