Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 )
Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19429/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19429/3//COMMIT_MSG@40 PS3, Line 40: try Nit: tries http://gerrit.cloudera.org:8080/#/c/19429/3//COMMIT_MSG@50 PS3, Line 50: always matches Could you explain why the first condition is true for tables/views? Is it because their types are also represented as structs? -- To view, visit http://gerrit.cloudera.org:8080/19429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f1e78e325baafbe23101909d47e82bf140a2d77 Gerrit-Change-Number: 19429 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 19 Jan 2023 14:12:02 +0000 Gerrit-HasComments: Yes
