Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 )
Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19429/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19429/2//COMMIT_MSG@41 PS2, Line 41: it's not a table > Shouldn't this be "it's not a struct"? I think I should reword it to: "masked_view" is not a table Note that the underlying TableRef is expected to be a BaseTableRef. http://gerrit.cloudera.org:8080/#/c/19429/2//COMMIT_MSG@44 PS2, Line 44: These are the conditions for returning the STAR paths directly: > After looking at the code again, aren't the conditions for returning the pa Ah, my bad! I said it in the reverse way.. It's the condition for nested struct path. -- To view, visit http://gerrit.cloudera.org:8080/19429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f1e78e325baafbe23101909d47e82bf140a2d77 Gerrit-Change-Number: 19429 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 19 Jan 2023 13:08:26 +0000 Gerrit-HasComments: Yes
