Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 )
Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking ...................................................................... Patch Set 5: (3 comments) Good to know that it's clear now. Thanks for the feedbacks! http://gerrit.cloudera.org:8080/#/c/19429/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19429/4//COMMIT_MSG@49 PS4, Line 49: paths > Nit: path Done http://gerrit.cloudera.org:8080/#/c/19429/4//COMMIT_MSG@50 PS4, Line 50: root t > Shouldn't it be 'root tuple descriptor'? Done http://gerrit.cloudera.org:8080/#/c/19429/4//COMMIT_MSG@56 PS4, Line 56: an > Nit: and Done -- To view, visit http://gerrit.cloudera.org:8080/19429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f1e78e325baafbe23101909d47e82bf140a2d77 Gerrit-Change-Number: 19429 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 20 Jan 2023 11:12:22 +0000 Gerrit-HasComments: Yes
