Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 )
Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. ...................................................................... Patch Set 6: (3 comments) A few more nits http://gerrit.cloudera.org:8080/#/c/19428/6/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/19428/6/be/src/transport/THttpServer.cpp@249 PS6, Line 249: VLOG_QUERY << "HTTP Connection Tracing" I think VLOG_QUERY is VLOG(1) and 1 is the default level (like INFO). I think this should be at a lower level, like VLOG(2) as it is not something you regularly want to see. http://gerrit.cloudera.org:8080/#/c/19428/6/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/19428/6/shell/impala_client.py@a816 PS6, Line 816: Was this line deliberately removed? http://gerrit.cloudera.org:8080/#/c/19428/6/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/19428/6/tests/shell/test_shell_commandline.py@29 PS6, Line 29: from time import sleep Nit: already imported on line 42 -- To view, visit http://gerrit.cloudera.org:8080/19428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7857eb5ec03eba32e06ec8d4133480f2e958ad2f Gerrit-Change-Number: 19428 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Sat, 21 Jan 2023 01:48:36 +0000 Gerrit-HasComments: Yes
