Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 )
Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. ...................................................................... Patch Set 7: Code-Review+1 (3 comments) LGTM, will let Abhishek take to +2 http://gerrit.cloudera.org:8080/#/c/19428/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19428/7//COMMIT_MSG@22 PS7, Line 22: The Impala shell includes these flags by default. Command line Nit: "includes these headers" http://gerrit.cloudera.org:8080/#/c/19428/7//COMMIT_MSG@23 PS7, Line 23: arguments have been added to remove these headers. Nit: say what the option is http://gerrit.cloudera.org:8080/#/c/19428/7//COMMIT_MSG@25 PS7, Line 25: The Impala backend logs out these headers if they are on the http Nit: say it's at log level 2 -- To view, visit http://gerrit.cloudera.org:8080/19428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7857eb5ec03eba32e06ec8d4133480f2e958ad2f Gerrit-Change-Number: 19428 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Thu, 02 Feb 2023 16:32:29 +0000 Gerrit-HasComments: Yes
