Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/19428 )
Change subject: IMPALA-11850 Adds HTTP tracing headers when using the hs2-http protocol. ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/19428/7/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/19428/7/be/src/transport/THttpServer.cpp@180 PS7, Line 180: boost::trim(header_x_request_id_); probably best to use StripWhiteSpace instead of boost::trim. It seems we've run into some issues with boost::trim in the past: https://github.com/apache/impala/commit/604e48d2f3f86b18f7d588d1861e17f177dfedc9 http://gerrit.cloudera.org:8080/#/c/19428/7/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/19428/7/shell/impala_client.py@434 PS7, Line 434: transport.addCustomHeaderFunc(self.get_custom_http_headers) Unless I'm missing something, the headers aren't getting updated for subsequent rpcs. Which would matter for X-Impala-Query-Id and X-Request-Id headers. I think we should update these headers either in _do_hs2_rpc() call or pass down the context to ImpalaHTTPClient and let it do header updates since it's already doing it for other headers: https://github.com/apache/impala/blob/master/shell/ImpalaHttpClient.py#L293 -- To view, visit http://gerrit.cloudera.org:8080/19428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7857eb5ec03eba32e06ec8d4133480f2e958ad2f Gerrit-Change-Number: 19428 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Thu, 02 Feb 2023 20:46:54 +0000 Gerrit-HasComments: Yes
