Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19548 )
Change subject: IMPALA-11795: Ignore high/low values stats for timestamp columns ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19548/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java File fe/src/main/java/org/apache/impala/catalog/ColumnStats.java: http://gerrit.cloudera.org:8080/#/c/19548/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@419 PS1, Line 419: * From the source 'longStats', set the low and high value for 'type' (one of the : * integer types). > nit: Add mention to never call this function for TIMESTAMP column. Done http://gerrit.cloudera.org:8080/#/c/19548/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@441 PS1, Line 441: case TIM > As additional precaution, can we add TIMESTAMP case here, but silently igno Added same a Precondition check specifically for TIMESTAMP to provide a clearer error if it actually gets called with TIMESTAMP. http://gerrit.cloudera.org:8080/#/c/19548/1/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@465 PS1, Line 465: break; > Add case to silently ignore TIMESTAMP as well here. Same as line 443 -- To view, visit http://gerrit.cloudera.org:8080/19548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If585d2543d49978140dcb7b8d49d6ea50e4a8544 Gerrit-Change-Number: 19548 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 27 Feb 2023 19:37:38 +0000 Gerrit-HasComments: Yes
