Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19548 )
Change subject: IMPALA-11795: Ignore high/low values stats for timestamp columns ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Thank you for accomodating my request in ps4. Restore the +2. http://gerrit.cloudera.org:8080/#/c/19548/2/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java File fe/src/main/java/org/apache/impala/catalog/ColumnStats.java: http://gerrit.cloudera.org:8080/#/c/19548/2/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@586 PS2, Line 586: if (colType.getPrimitiveType() != PrimitiveType.TIMESTAMP) { : // Low/high value handling is not yet implemented for timestamps. : setLowAndHighValue(colType.getPrimitiveType(), longStats); : } > Riza, do you think that Yes. To me, it is better to check the PrimitiveType here. All switches in update() and setLowAndHighValue() check for the PrimitiveType. It is unlikely that Impala will have another Type with TIMESTAMP primitive in the future. But if we do, we'll surely hit the same error. -- To view, visit http://gerrit.cloudera.org:8080/19548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If585d2543d49978140dcb7b8d49d6ea50e4a8544 Gerrit-Change-Number: 19548 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 01 Mar 2023 15:57:09 +0000 Gerrit-HasComments: Yes
