Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19548 )
Change subject: IMPALA-11795: Ignore high/low values stats for timestamp columns ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19548/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19548/2//COMMIT_MSG@12 PS2, Line 12: "U > nit: Replace with single quote. Done http://gerrit.cloudera.org:8080/#/c/19548/2/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java File fe/src/main/java/org/apache/impala/catalog/ColumnStats.java: http://gerrit.cloudera.org:8080/#/c/19548/2/fe/src/main/java/org/apache/impala/catalog/ColumnStats.java@586 PS2, Line 586: if (colType != Type.TIMESTAMP) { : // Low/high value handling is not yet implemented for timestamps. : setLowAndHighValue(colType.getPrimitiveType(), longStats); : } > Is this a dead code? The only colType with primitive type TIMESTAMP is Type I am not sure if I understand the comment correctly. 5 cases above go to the same block - 4 int types and TIMESTAMP. The logic is the same for all of them, with the exception of high/low values, which doesn't handle TIMESTAMP -- To view, visit http://gerrit.cloudera.org:8080/19548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If585d2543d49978140dcb7b8d49d6ea50e4a8544 Gerrit-Change-Number: 19548 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 28 Feb 2023 15:47:24 +0000 Gerrit-HasComments: Yes
