Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19561 )
Change subject: IMPALA-11726: Allow LDAP user and group filter when Kerberos is enabled ...................................................................... Patch Set 6: (2 comments) Hi Gergely, thanks for this feature, looks great and nice test coverage. I have added a question and a nit. I will do another round tomorrow. http://gerrit.cloudera.org:8080/#/c/19561/6/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/19561/6/be/src/rpc/authentication.cc@570 PS6, Line 570: const char* requested_user, unsigned rlen, : const char* auth_identity, unsigned alen, : const char* def_realm, unsigned urlen, : struct propctx* propctx) { nit: Could we keep the original formatting? It is closer to the one used in this file. http://gerrit.cloudera.org:8080/#/c/19561/6/be/src/rpc/authentication.cc@988 PS6, Line 988: if (FLAGS_enable_ldap_auth || IsKerberosEnabled()) { Do I understand it right that, this will evaluate to true, then the next condition as well (L989 & L1017), which will cause the TSaslServerTransport to have 3 callbacks in case of LDAP+Kerberos configuration? -- To view, visit http://gerrit.cloudera.org:8080/19561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3ca9c4ff8a17167e5233afabdd14c948edb46de Gerrit-Change-Number: 19561 Gerrit-PatchSet: 6 Gerrit-Owner: Gergely Farkas <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Farkas <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 06 Mar 2023 16:17:44 +0000 Gerrit-HasComments: Yes
