Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19561 )
Change subject: IMPALA-11726: Allow LDAP user and group filter when Kerberos is enabled ...................................................................... Patch Set 7: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/19561/7/be/src/rpc/authentication-test.cc File be/src/rpc/authentication-test.cc: http://gerrit.cloudera.org:8080/#/c/19561/7/be/src/rpc/authentication-test.cc@27 PS7, Line 27: #include "util/kudu-status-util.h" : #include "kudu/security/test/mini_kdc.h" includes are generally sorted ¬alphabetically in Impala http://gerrit.cloudera.org:8080/#/c/19561/4/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/19561/4/be/src/rpc/authentication.cc@569 PS4, Line 569: SaslLdapAuthorizeExternal > At first I wanted to use the SASL_CB_SERVER_USERDB_CHECKPASS callback, the ack http://gerrit.cloudera.org:8080/#/c/19561/7/fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java File fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java: http://gerrit.cloudera.org:8080/#/c/19561/7/fe/src/test/java/org/apache/impala/customcluster/KerberosKdcEnvironment.java@102 PS7, Line 102: nit: extra line http://gerrit.cloudera.org:8080/#/c/19561/7/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/19561/7/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@273 PS7, Line 273: TEST_USER_1 The proxy and the delegated user are the same here, which seems like a special case. Is this intentional? http://gerrit.cloudera.org:8080/#/c/19561/7/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@502 PS7, Line 502: enable_ldap_auth This seems to be exactly the same as the ldap flags in testShellKerberosAuthWithCustomLdapFiltersAndSimpleBindNoGroupFilterCheck() and testLdapFiltersWithProxyWithKerberosAuthAndLdapSimpleBind(). Maybe this could be moved a function like getLdapSimpleBindFlags(). -- To view, visit http://gerrit.cloudera.org:8080/19561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3ca9c4ff8a17167e5233afabdd14c948edb46de Gerrit-Change-Number: 19561 Gerrit-PatchSet: 7 Gerrit-Owner: Gergely Farkas <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Farkas <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:05:28 +0000 Gerrit-HasComments: Yes
