Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19561 )
Change subject: IMPALA-11726: Allow LDAP user and group filter when Kerberos is enabled ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Thanks Gergely, LGTM! http://gerrit.cloudera.org:8080/#/c/19561/6/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/19561/6/be/src/rpc/authentication.cc@988 PS6, Line 988: if (FLAGS_enable_ldap_auth || IsKerberosEnabled()) { > Makes sense! Thank you for the detailed explanation Gergely, it is clear now. -- To view, visit http://gerrit.cloudera.org:8080/19561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3ca9c4ff8a17167e5233afabdd14c948edb46de Gerrit-Change-Number: 19561 Gerrit-PatchSet: 7 Gerrit-Owner: Gergely Farkas <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Farkas <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 08 Mar 2023 13:25:19 +0000 Gerrit-HasComments: Yes
