Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG@9 PS2, Line 9: > I think that Impala could also use this new API: This API implementation in HMS only supports Insert and reload events from Impala. We'll have to change this HMS implementation every single time a new API is introduced (along with impala changes). I don't think that would be ideal. http://gerrit.cloudera.org:8080/#/c/19508/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19508/3//COMMIT_MSG@9 PS3, Line 9: In the MetastoreServiceHandler class, the > We use a line length limit of 72 columns in the commit message. Ack http://gerrit.cloudera.org:8080/#/c/19508/3/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/19508/3/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2415 PS3, Line 2415: WriteN > Indentation in case of line continuation should be 4. Ack http://gerrit.cloudera.org:8080/#/c/19508/3/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/19508/3/tests/custom_cluster/test_metastore_service.py@988 PS3, Line 988: MetastoreServiceHandler in impala can talk to HMS through these APIs): > Nit: some of this line fits on the previous line (max line length is 90). Ack -- To view, visit http://gerrit.cloudera.org:8080/19508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194 Gerrit-Change-Number: 19508 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 10 Mar 2023 05:35:59 +0000 Gerrit-HasComments: Yes
