Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19508 )
Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG@9 PS2, Line 9: add_write_notification_log_ > add_write_notification_log_in_batch seems to be the batched version of add_ That's a good suggestion. I don't we would use this API at all in Impala. Since MetastoreServiceHandler class extends AbstractThriftHiveMetastore class and every time a new API is introduced in AbstractThriftHiveMetastore class we'll have to define it in MetastoreServiceHandler class. http://gerrit.cloudera.org:8080/#/c/19508/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19508/4//COMMIT_MSG@9 PS4, Line 9: In the MetastoreServiceHandler class, the 'add_write_notification_log_ > This is now 42, the limit is 72. Ack http://gerrit.cloudera.org:8080/#/c/19508/4//COMMIT_MSG@19 PS4, Line 19: Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194 > Line too long (74 vs 72). Ack -- To view, visit http://gerrit.cloudera.org:8080/19508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194 Gerrit-Change-Number: 19508 Gerrit-PatchSet: 5 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 23 Mar 2023 14:48:01 +0000 Gerrit-HasComments: Yes
