Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19508 )

Change subject: IMPALA-11925: Added a new api 
add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19508/2//COMMIT_MSG@9
PS2, Line 9:
> This API implementation in HMS only supports Insert and reload events from
add_write_notification_log_in_batch seems to be the batched version of 
add_write_notification_log, an API we already use (through 
IMetaStoreClient.addWriteNotificationLog() ). So I thought that we only need to 
change Impala, not Hive to use a more efficient API.

Checked IMetaStoreClient, and addWriteNotificationLogInBatch() is added to it.



-- 
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: John Sherman <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Mon, 13 Mar 2023 09:42:46 +0000
Gerrit-HasComments: Yes

Reply via email to