Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19688 )
Change subject: IMPALA-12036: Fix Web UI to show right resource pools ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/19688/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19688/5//COMMIT_MSG@9 PS5, Line 9: Web queries site shows no resource pool unless it is specified with > Are you referring to the Admission WebUI? With unit tests, /queries Web UI Done http://gerrit.cloudera.org:8080/#/c/19688/5//COMMIT_MSG@14 PS5, Line 14: fixe > fixes Done http://gerrit.cloudera.org:8080/#/c/19688/5/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/19688/5/be/src/service/client-request-state.h@255 PS5, Line 255: && exec_request_->query_exec_request.query_ctx.__isset.request_pool) { > I will add atomic_bool is_planning_done_. It will be set as true after plan Done http://gerrit.cloudera.org:8080/#/c/19688/4/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/19688/4/tests/custom_cluster/test_admission_controller.py@307 PS4, Line 307: > The warning suggests making this a r"..." (raw literal) string. https://www Thanks, will fix it. http://gerrit.cloudera.org:8080/#/c/19688/5/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/19688/5/tests/custom_cluster/test_admission_controller.py@307 PS5, Line 307: t > flake8: W605 invalid escape sequence '\S' Done -- To view, visit http://gerrit.cloudera.org:8080/19688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceacb3a8ec3bd15a8029ba05d064bbbb81e3a766 Gerrit-Change-Number: 19688 Gerrit-PatchSet: 6 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 05 Apr 2023 00:29:53 +0000 Gerrit-HasComments: Yes
