Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19688 )
Change subject: IMPALA-12036: Fix Web UI to show right resource pools ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19688/5/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/19688/5/be/src/service/client-request-state.h@255 PS5, Line 255: if (exec_request_->query_exec_request.query_ctx.__isset.request_pool) { > I don't think that this is actually thread-safe since exec_request_ may not Looking at thrift code, the is_set flag is updated after assignments for both __set_request_pool and TQueryCtx::operator= but there are no explicit memory barriers. Since this should be updated from the planner thrift, it should be using TQueryCtx::operator= and most likely is safe enough since there are many other members assigned before the is_set flags. -- To view, visit http://gerrit.cloudera.org:8080/19688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceacb3a8ec3bd15a8029ba05d064bbbb81e3a766 Gerrit-Change-Number: 19688 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 04 Apr 2023 19:34:46 +0000 Gerrit-HasComments: Yes
