Wenzhe Zhou has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19688 )

Change subject: IMPALA-12036: Fix Web UI to show right resource pools
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19688/5/be/src/service/client-request-state.h
File be/src/service/client-request-state.h:

http://gerrit.cloudera.org:8080/#/c/19688/5/be/src/service/client-request-state.h@255
PS5, Line 255:     if 
(exec_request_->query_exec_request.query_ctx.__isset.request_pool) {
> Looking at thrift code, the is_set flag is updated after assignments for bo
I will add atomic_bool is_planning_done_. It will be set as true after planning 
is done. We check exec_request_->query_exec_request.query_ctx only 
is_planning_done_ is done.



--
To view, visit http://gerrit.cloudera.org:8080/19688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceacb3a8ec3bd15a8029ba05d064bbbb81e3a766
Gerrit-Change-Number: 19688
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Tue, 04 Apr 2023 21:08:38 +0000
Gerrit-HasComments: Yes

Reply via email to