Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19660 )
Change subject: WIP - IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/19660/3/be/src/runtime/raw-value.h File be/src/runtime/raw-value.h: http://gerrit.cloudera.org:8080/#/c/19660/3/be/src/runtime/raw-value.h@175 PS3, Line 175: const SlotDescriptor* slot_desc, MemPool* pool, std::vector<StringValue*>* string_values, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/19660/3/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: http://gerrit.cloudera.org:8080/#/c/19660/3/be/src/runtime/sorter.cc@731 PS3, Line 731: // This must be the first slot with var len data for the tuple. Var len data line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/19660/3/be/src/runtime/sorter.cc@776 PS3, Line 776: // This must be the first slot with var len data for the tuple. Var len data line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/19660/3/be/src/runtime/tuple.cc File be/src/runtime/tuple.cc: http://gerrit.cloudera.org:8080/#/c/19660/3/be/src/runtime/tuple.cc@250 PS3, Line 250: for (const pair<CollectionValue*, int64_t>& collection_val_pair : collection_values) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19660/3/be/src/runtime/tuple.cc@370 PS3, Line 370: // void MaterializeExprs(Tuple* opaque_tuple, TupleRow* row, const TupleDescriptor& desc, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19660/3/be/src/runtime/tuple.cc@372 PS3, Line 372: // StringValue** non_null_string_values, CollValueAndSize* non_null_collection_values, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19660/3/tests/query_test/test_sort.py File tests/query_test/test_sort.py: http://gerrit.cloudera.org:8080/#/c/19660/3/tests/query_test/test_sort.py@25 PS3, Line 25: def split_result_rows(result): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/19660/3/tests/query_test/test_sort.py@296 PS3, Line 296: \ flake8: E502 the backslash is redundant between brackets -- To view, visit http://gerrit.cloudera.org:8080/19660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7974ef392c1412e8c60231e3420367bd189677a Gerrit-Change-Number: 19660 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 14 Apr 2023 10:00:28 +0000 Gerrit-HasComments: Yes
