Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19660 )
Change subject: IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/19660/8/testdata/ComplexTypesTbl/simple_arrays_big.parq File testdata/ComplexTypesTbl/simple_arrays_big.parq: http://gerrit.cloudera.org:8080/#/c/19660/8/testdata/ComplexTypesTbl/simple_arrays_big.parq@1 PS8, Line 1: PAR1 â â ,À¸ % % ( Q R & vUQ c E = B J 7 = R Å]0 2"^ + ^ 7 N = . * K % \ 0 v~d 1 K 0 W < C ` = ( _ _ H https://github.com/apache/impala/blob/master/testdata/data/README ? also, would it be very hard to generate this during dataload? There are some files bigger than this in the repo, but avoiding adding it would be nice http://gerrit.cloudera.org:8080/#/c/19660/7/testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test File testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test: http://gerrit.cloudera.org:8080/#/c/19660/7/testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test@38 PS7, Line 38: # Same collection used twice in a select list. > Moved to sort.test. Oops, no I am worried that this will cause problems when sort.test is run with other table formats than Parquet/ORC https://github.com/apache/impala/blob/63d13a35f35874822daf167d763ed683f1ec48ef/tests/query_test/test_queries.py#L46 Can you separate the sort related tests to another .test file and running it if the file format is not ORC/Parquet? http://gerrit.cloudera.org:8080/#/c/19660/7/tests/query_test/test_sort.py File tests/query_test/test_sort.py: http://gerrit.cloudera.org:8080/#/c/19660/7/tests/query_test/test_sort.py@296 PS7, Line 296: if cls.exploration_strategy() == 'core': : cls.ImpalaTestMatrix.add_constraint(lambda v: : v.get_value('table_format').file_format == 'parquet') Having more file formats doesn't seem useful as functional_parquet.simple_arrays_big is baked in in the query -- To view, visit http://gerrit.cloudera.org:8080/19660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7974ef392c1412e8c60231e3420367bd189677a Gerrit-Change-Number: 19660 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 12 May 2023 06:56:37 +0000 Gerrit-HasComments: Yes
