Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19660 )
Change subject: WIP - IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19660/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19660/2//COMMIT_MSG@16 PS2, Line 16: > I don't think we have infrastructure to only disable codegen for the sorter I think that is enough to simply return an error during codegen - codegen errors do not result in query failure just simply reverting to interpreted path and adding a message to the profile https://github.com/apache/impala/blob/175dae33d9a224ef69decc2d3887e847755d4c9e/be/src/exec/sort-node.cc#L123 -- To view, visit http://gerrit.cloudera.org:8080/19660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7974ef392c1412e8c60231e3420367bd189677a Gerrit-Change-Number: 19660 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 14 Apr 2023 10:36:29 +0000 Gerrit-HasComments: Yes
