wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18023 )
Change subject: IMPALA-7942 (part 2): Add query hints for predicate selectivities ...................................................................... Patch Set 33: (1 comment) http://gerrit.cloudera.org:8080/#/c/18023/33/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java File fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java: http://gerrit.cloudera.org:8080/#/c/18023/33/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java@155 PS33, Line 155: analyzer.addWarning("Selectivity hint is invalid for 'AND' compound predicates."); > Will this appear for BETWEEN predicate also? Currently, this warning will not appear for BETWEEN predicate, since I removed selectivity assgined in 'BetweenToCompoundRule.java' when transform BetweenPredicate to CompoundPredicate. If we want to appear for BETWEEN predicate also, we need to add code in 'BetweenToCompoundRule.java' like this: CompoundPredicate result = new CompoundPredicate(compoundOperator, lower, upper); result.setSelectivityHint(bp.getSelectivity()); return result; How do you think? -- To view, visit http://gerrit.cloudera.org:8080/18023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2776b9bbd878b8a21d9c866b400140a454f59e1b Gerrit-Change-Number: 18023 Gerrit-PatchSet: 33 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 18 Apr 2023 02:30:44 +0000 Gerrit-HasComments: Yes
