Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18023 )
Change subject: IMPALA-7942 (part 2): Add query hints for predicate selectivities ...................................................................... Patch Set 33: (7 comments) Looks very good! http://gerrit.cloudera.org:8080/#/c/18023/33//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18023/33//COMMIT_MSG@12 PS33, Line 12: , we can use this : hint nit. remove and replace with "to help specify" http://gerrit.cloudera.org:8080/#/c/18023/33//COMMIT_MSG@18 PS33, Line 18: , in the range of [0, 1], http://gerrit.cloudera.org:8080/#/c/18023/33//COMMIT_MSG@29 PS33, Line 29: But pay attention, selectivity hint is invalid for 'AND' compound : predicates and between predicates in this patch As a limitation of this path, the selectivity hints for 'AND' compound predicates, either in the original SQL query or internally generated, are ignored. http://gerrit.cloudera.org:8080/#/c/18023/33//COMMIT_MSG@31 PS33, Line 31: this in the near future. May file a new JIRA and mention the JIRA number here. http://gerrit.cloudera.org:8080/#/c/18023/33/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java File fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java: http://gerrit.cloudera.org:8080/#/c/18023/33/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java@153 PS33, Line 153: // 'AND' compound predicates will replaced by children in Expr#getConjuncts, so nit be http://gerrit.cloudera.org:8080/#/c/18023/33/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java@154 PS33, Line 154: // selectivity hint will missing, we add a warning here. nit be http://gerrit.cloudera.org:8080/#/c/18023/33/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java@155 PS33, Line 155: analyzer.addWarning("Selectivity hint is invalid for 'AND' compound predicates."); > Currently, this warning will not appear for BETWEEN predicate, since I remo There is one case in CaseExpr.java where the translation to AND predicate takes place. I think we can change the warning message to something like below to cover all such cases. "Selectivity hints are ignored for 'AND' compound predicates, either in the SQL query or internally generated." -- To view, visit http://gerrit.cloudera.org:8080/18023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2776b9bbd878b8a21d9c866b400140a454f59e1b Gerrit-Change-Number: 18023 Gerrit-PatchSet: 33 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 18 Apr 2023 22:54:33 +0000 Gerrit-HasComments: Yes
