wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18023 )
Change subject: IMPALA-7942 (part 2): Add query hints for predicate selectivities ...................................................................... Patch Set 34: (7 comments) http://gerrit.cloudera.org:8080/#/c/18023/33//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18023/33//COMMIT_MSG@12 PS33, Line 12: to help specify a : sele > nit. remove and replace with "to help specify" Done http://gerrit.cloudera.org:8080/#/c/18023/33//COMMIT_MSG@18 PS33, Line 18: , > , in the range of [0, 1], Done http://gerrit.cloudera.org:8080/#/c/18023/33//COMMIT_MSG@29 PS33, Line 29: As a limitation of this path, the selectivity hints for 'AND' compound : predicates, either in the original SQL query or > As a limitation of this path, the selectivity hints for 'AND' compound pred Done http://gerrit.cloudera.org:8080/#/c/18023/33//COMMIT_MSG@31 PS33, Line 31: are ignored. We may supported this in the near future. > May file a new JIRA and mention the JIRA number here. I didn't create a new JIRA yet, so not JIRA number provided here. http://gerrit.cloudera.org:8080/#/c/18023/33/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java File fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java: http://gerrit.cloudera.org:8080/#/c/18023/33/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java@153 PS33, Line 153: // 'AND' compound predicates will be replaced by children in Expr#getConjuncts, > nit be Done http://gerrit.cloudera.org:8080/#/c/18023/33/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java@154 PS33, Line 154: // so selectivity hint will be missing, we add a warning here. > nit be Done http://gerrit.cloudera.org:8080/#/c/18023/33/fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java@155 PS33, Line 155: analyzer.addWarning("Selectivity hints are ignored for 'AND' compound " > There is one case in CaseExpr.java where the translation to AND predicate t Done -- To view, visit http://gerrit.cloudera.org:8080/18023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2776b9bbd878b8a21d9c866b400140a454f59e1b Gerrit-Change-Number: 18023 Gerrit-PatchSet: 34 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Wed, 19 Apr 2023 13:02:31 +0000 Gerrit-HasComments: Yes
