Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19796 )
Change subject: IMPALA-12090: Split runtime profiles made by single_node_perf_run.py ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19796/2/bin/single_node_perf_run.py File bin/single_node_perf_run.py: http://gerrit.cloudera.org:8080/#/c/19796/2/bin/single_node_perf_run.py@187 PS2, Line 187: sh.diff("-u", : os.path.join(base_dir, hash_a + "_profiles"), : os.path.join(base_dir, hash_b + "_profiles"), : _out=os.path.join(IMPALA_HOME, "performance_result_profile_diff.txt"), : _ok_code=[0, 1]) This diff might have some issues once we split up the files. If I have two directories: a/ /one_filename.txt b/ /other_filename.txt Then diff can't line up the file names and I get messages like this: $ diff -u a b Only in a: one_filename.txt Only in b: other_filename.txt To make this work, maybe we need to drop the query id from the file name. We'll have to check the output. http://gerrit.cloudera.org:8080/#/c/19796/2/bin/single_node_perf_run.py@243 PS2, Line 243: {} Small nit: Let's pad it with zeros (i.e. 001, 002, ..., 010) To do that, we can use: '{:03d}' -- To view, visit http://gerrit.cloudera.org:8080/19796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc2d3cefd7ad61b76cbef74c734543ef9ca51795 Gerrit-Change-Number: 19796 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 24 Apr 2023 19:54:11 +0000 Gerrit-HasComments: Yes
