Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19796 )
Change subject: IMPALA-12090: Split runtime profiles made by single_node_perf_run.py ...................................................................... Patch Set 3: Code-Review+1 (1 comment) This is looking good to me http://gerrit.cloudera.org:8080/#/c/19796/3/bin/single_node_perf_run.py File bin/single_node_perf_run.py: http://gerrit.cloudera.org:8080/#/c/19796/3/bin/single_node_perf_run.py@332 PS3, Line 332: parser.add_option("--split_profiles", action="store_true", : help="If true, query profiles will be generated as separate files") I'm thinking that we might want the split profiles to be the default at some point. When we do, we could introduce a "--no_split_profiles" option that stores false into split_profiles. We can decide whether we should switch the default now or later. This example over at the optparse documentation can help (https://docs.python.org/2.7/library/optparse.html#default-values ) Something like this might work: parser.add_option("--split_profiles", dest="split_profiles", action="store_true", default=True, ...) parser.add_option("--no_split_profiles, dest="split_profiles", action="store_false", ...) -- To view, visit http://gerrit.cloudera.org:8080/19796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc2d3cefd7ad61b76cbef74c734543ef9ca51795 Gerrit-Change-Number: 19796 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 00:21:20 +0000 Gerrit-HasComments: Yes
