Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19796 )
Change subject: IMPALA-12090: Split runtime profiles made by single_node_perf_run.py ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19796/3/bin/single_node_perf_run.py File bin/single_node_perf_run.py: http://gerrit.cloudera.org:8080/#/c/19796/3/bin/single_node_perf_run.py@332 PS3, Line 332: parser.add_option("--split_profiles", action="store_true", dest="split_profiles", : default=True, help=("If specified, query profiles will be generated > I'm thinking that we might want the split profiles to be the default at som I'm fine with splitting profiles as default. ps4 adds --no_split_profiles as well. -- To view, visit http://gerrit.cloudera.org:8080/19796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc2d3cefd7ad61b76cbef74c734543ef9ca51795 Gerrit-Change-Number: 19796 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 15:48:12 +0000 Gerrit-HasComments: Yes
