Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: Fix INVALIDATE METADATA under unloaded db still send full db objects in LocalCatalog mode ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-12084: Fix INVALIDATE METADATA under unloaded db still send full db objects in LocalCatalog mode nit: this title is kind of long http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG@12 PS1, Line 12: full db object. This is a missing logic we should add in IMPALA-9936. The last sentence implies we need to do something else. I think you meant the past-tense, as in "we should have added in IMPALA-9936", since that ticket is complete. http://gerrit.cloudera.org:8080/#/c/19787/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/19787/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@a7217 PS1, Line 7217: We really want to remove this for all calls to addDbToCatalogUpdate? -- To view, visit http://gerrit.cloudera.org:8080/19787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5 Gerrit-Change-Number: 19787 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 24 Apr 2023 22:55:06 +0000 Gerrit-HasComments: Yes
