Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2 ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2 > nit: this title is kind of long Done http://gerrit.cloudera.org:8080/#/c/19787/1//COMMIT_MSG@12 PS1, Line 12: full db object. This is a missing logic we should have added in > The last sentence implies we need to do something else. I think you meant t Yeah, thanks for correcting this! http://gerrit.cloudera.org:8080/#/c/19787/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/19787/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@a7217 PS1, Line 7217: > We really want to remove this for all calls to addDbToCatalogUpdate? This is a no-op since it sets the version by getting the version from itself. I think it's added by mistake. -- To view, visit http://gerrit.cloudera.org:8080/19787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5 Gerrit-Change-Number: 19787 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 26 Apr 2023 23:05:20 +0000 Gerrit-HasComments: Yes
