Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 )
Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2 ...................................................................... Patch Set 3: (1 comment) Thanks, looks good to me. I only have a bit unrelated comment, it's up to you whether you want to implement it. http://gerrit.cloudera.org:8080/#/c/19787/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/19787/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6359 PS3, Line 6359: three Optional: not connected to this change but now we have 4 things in the list, so we could update this. To be future proof we could change this to "these things" instead of "four things". -- To view, visit http://gerrit.cloudera.org:8080/19787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38a44f69cca20331ab31acc270c2921a7bfedae5 Gerrit-Change-Number: 19787 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 28 Apr 2023 09:26:37 +0000 Gerrit-HasComments: Yes
