Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19745 )
Change subject: IMPALA-11970: Shifting the timeline display to SVG ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@39 PS3, Line 39: <input type="checkbox" id="plan_order" onClick="refresh()"/> Did you mean to change this to refresh() ? http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@148 PS3, Line 148: svg.appendChild(get_svg_rect(phases[color_idx].color, x + 1, y + 1, Missing width>2 check http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@330 PS3, Line 330: var plan_order=document.getElementById('plan_order').checked; spaces around = -- To view, visit http://gerrit.cloudera.org:8080/19745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I083c2ec12e1743b89092fc23281ee576d66fa81b Gerrit-Change-Number: 19745 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 14:55:19 +0000 Gerrit-HasComments: Yes
