Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19745 )
Change subject: IMPALA-11970: Shifting the timeline display to SVG ...................................................................... Patch Set 3: (11 comments) http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@97 PS3, Line 97: return rect; nit: indent two spaces http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@100 PS3, Line 100: fill_color nit: add space after comma http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@111 PS3, Line 111: != nit: add space around != http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@157 PS3, Line 157: if (Math.abs(dx) > ignore_px){ nit: add space in front of { http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@158 PS3, Line 158: nit: indent two spaces http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@337 PS3, Line 337: = nit: add space around "=" in this line and following two lines. http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@363 PS3, Line 363: , nit: add space after , http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@428 PS3, Line 428: ); nit: don't split as separate line http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@444 PS3, Line 444: ); nit don't split as separate line http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@494 PS3, Line 494: x+1, y+1 nit: add spaces around + http://gerrit.cloudera.org:8080/#/c/19745/3/www/query_timeline.tmpl@497 PS3, Line 497: * nit: add space around * -- To view, visit http://gerrit.cloudera.org:8080/19745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I083c2ec12e1743b89092fc23281ee576d66fa81b Gerrit-Change-Number: 19745 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 16:34:42 +0000 Gerrit-HasComments: Yes
