Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19745 )
Change subject: IMPALA-11970: Shifting the timeline display to SVG ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19745/1/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19745/1/www/query_timeline.tmpl@351 PS1, Line 351: fragment_diagram.setAttribute("height",rownum * height + "px"); Spaces after commas on next 4 lines http://gerrit.cloudera.org:8080/#/c/19745/1/www/query_timeline.tmpl@450 PS1, Line 450: if (node.is_sender && node.parent_node.rendering.rownum != rownum - 1) { Please fix a minor bug that was introduced here in the previously commit. Since rownum is not maintained in this loop, there are cases that don't draw the short path to parent when plan ordering is checked. -- To view, visit http://gerrit.cloudera.org:8080/19745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I083c2ec12e1743b89092fc23281ee576d66fa81b Gerrit-Change-Number: 19745 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Mon, 24 Apr 2023 23:36:12 +0000 Gerrit-HasComments: Yes
