Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19810 )
Change subject: IMPALA-12102: This patch avoids memory leaks due to the large number of JNI exceptions thrown ...................................................................... Patch Set 2: (3 comments) Thanks for your work. I'm not a JNI expert but here are some comments. http://gerrit.cloudera.org:8080/#/c/19810/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19810/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-12102: This patch avoids memory leaks due to the large number of JNI exceptions thrown This would be a less verbose title: "Avoid memory leaks in the handling of JNI exceptions". http://gerrit.cloudera.org:8080/#/c/19810/2/be/src/util/jni-util.cc File be/src/util/jni-util.cc: http://gerrit.cloudera.org:8080/#/c/19810/2/be/src/util/jni-util.cc@292 PS2, Line 292: auto Using the actual type is more readable. In this case it should be const char*. http://gerrit.cloudera.org:8080/#/c/19810/2/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/19810/2/tests/query_test/test_udfs.py@695 PS2, Line 695: def test_throws_exception(self, vector, unique_database): How does this test that we don't leak memory? -- To view, visit http://gerrit.cloudera.org:8080/19810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4843df07dd0f9d3dc237f91db4ec00721ebbd680 Gerrit-Change-Number: 19810 Gerrit-PatchSet: 2 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Thu, 27 Apr 2023 16:04:21 +0000 Gerrit-HasComments: Yes
