Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19810 )
Change subject: IMPALA-12102: Avoid memory leaks in the handling of JNI exceptions ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Thanks, it looks good, I left just one comment. Also, let's wait to see if Quanlong can review it. http://gerrit.cloudera.org:8080/#/c/19810/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19810/3//COMMIT_MSG@14 PS3, Line 14: - Passed validation in the local development environment. If you could manually verify that the mem leak doesn't occur, it would be clearer to write that, for example "Manually verified that the memory leak doesn't occur." -- To view, visit http://gerrit.cloudera.org:8080/19810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4843df07dd0f9d3dc237f91db4ec00721ebbd680 Gerrit-Change-Number: 19810 Gerrit-PatchSet: 3 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Wed, 03 May 2023 09:37:46 +0000 Gerrit-HasComments: Yes
